bero updated this revision to Diff 76032. bero added a comment.
Probably best to just add a comment explaining what needs to be done if AccountModel::* roles ever diverge from DisplayRole/DecorationRole... Leaving the code the way it is now will result in a harder to trace error if Qt ever changes the values of DisplayRole or DecorationRole (and may give people looking at the code bad ideas), revising it the way I proposed earlier causes duplicate case values. REPOSITORY R128 User Manager CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D27514?vs=76031&id=76032 REVISION DETAIL https://phabricator.kde.org/D27514 AFFECTED FILES src/lib/accountmodel.cpp To: bero, #plasma, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
