davidedmundson added inline comments.

INLINE COMMENTS

> broulik wrote in startup.cpp:429
> Could probably use an `m_service.isEmpty()` check since it will still 
> needlessly do a `NameHasOwner` call

All usages of this class (which is just the 1 case to start ksmserver!) have a 
name passed.

Without a name it wouldn't ever finish.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27471

To: davidedmundson, #plasma, apol
Cc: broulik, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Reply via email to