ngraham added inline comments.

INLINE COMMENTS

> main.qml:44
>      property bool vertical: plasmoid.formFactor === PlasmaCore.Types.Vertical
> -    readonly property int itemSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]]))
> +    readonly property int baseSize: 
> units.roundToIconSize(Math.min(Math.min(width, height), 
> units.iconSizes[iconSizes[Math.min(iconSizes.length-1, iconSize)]]))
> +    readonly property int itemSize: {

this doesn't need to be a property; just make it a variable (`var baseSize = 
...`) inside the new inline function itself.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27465

To: The-Feren-OS-Dev, ngraham, #vdg
Cc: davidre, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra, mart

Reply via email to