ngraham resigned from this revision.
ngraham added a comment.

  I have a vertical panel and use large tray icons but intentionally minimize 
their number, and the result looks fine to me IMO: F8107338: 
Screenshot_20200216_115030.png <https://phabricator.kde.org/F8107338>
  
  However I'll admit that I thought the status quo was fine too. So I have no 
particular opinion on the aesthetics of this patch, but I think we should be 
careful to avoid adding too much spacing because the people who have and like 
lots of tray icons have a legitimate concern here. To me, `units.smallSpacing` 
(i.e. 2) is the absolute max we should do.
  
  To make this patch easier to review without applying it, please add all the 
various sets of before-and-after images to the Test Plan section, not in 
comments.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg
Cc: ndavis, anthonyfieroni, davidre, ngraham, plasma-devel, Orage, LeGast00n, 
The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra, mart

Reply via email to