ngraham requested changes to this revision.
ngraham added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> main.qml:290
>          id: tasksRow
> -        spacing: 0
> +        spacing: 3
>          height: parent.height - (vertical && expander.visible ? 
> expander.height : 0)

Don't use magic values. How about `units.smallSpacing` would be more 
semantically appropriate. That maps to 2, BTW. If 2 is still too cramped, you 
could do `units.smallSpacing * 1.5` but using default spacing values is 
probably preferred.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D27438

To: The-Feren-OS-Dev, #vdg, ngraham
Cc: ngraham, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to