meven added inline comments. INLINE COMMENTS
> bport wrote in componentchooserbrowser.cpp:107 > add a space between - and 1 > > By the way this check seems strange to me, can you confirm it still allow to > save custom browser ? Once the user has added browsers to the list, they appear as before last entries. ` insertItem(count() -1, QIcon::fromTheme(icon), service->name(), service->storageId())` insert before count() - 1 the custom browser, line 58 The last entry is always "Other", whose index is count() - 1. So this still allows custom browsers. REPOSITORY R119 Plasma Desktop REVISION DETAIL https://phabricator.kde.org/D27395 To: meven, bport, ervin, crossi Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
