ahiemstra requested changes to this revision.
ahiemstra added a comment.
This revision now requires changes to proceed.


  I agree with what @cfeck says. I can also already think of at least one case 
where even a 256KiB buffer would be too small, which is a dual-cpu Epyc system, 
where you can potentially have 128 cores / 256 threads.
  
  That said, I think a short-term buffer size bump is fine, I'd just increase 
it a bit more than 256, maybe make it 1024.
  
  Additionally, please add a comment regarding the limitations of the buffer 
size above the define, so that we can find some trace of this discussion in the 
future.

REPOSITORY
  R106 KSysguard

REVISION DETAIL
  https://phabricator.kde.org/D27362

To: jakobkummerow, davidedmundson, ahiemstra
Cc: ahiemstra, cfeck, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, mart

Reply via email to