broulik accepted this revision. broulik added inline comments. This revision is now accepted and ready to land.
INLINE COMMENTS > handlebuttonevents.cpp:79 > + accel->setGlobalShortcut(globalAction, Qt::Key_PowerDown); > + connect(globalAction, SIGNAL(triggered(bool)), > SLOT(powerDownButtonTriggered())); > + Use new connect syntax in new code please > powerdevilbackendinterface.h:69 > * - PowerButton: A power button pressed event, generally used to turn > on or off the system > * - SleepButton: A sleep button pressed event, generally used to make > the system asleep > * - LidOpen: A laptop lid open event Please document what `PowerDownButton` is, especially that it has this magic behavior in kglobalaccel REPOSITORY R122 Powerdevil BRANCH master REVISION DETAIL https://phabricator.kde.org/D27193 To: apol, #plasma, bshah, broulik Cc: broulik, PureTryOut, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, cblack, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
