gvgeo added inline comments.

INLINE COMMENTS

> ListItemBase.qml:111
>                  id: column
> -                spacing: 0
> +                Layout.minimumHeight: contextMenuButton.implicitHeight * 2 + 
> units.smallSpacing
> +                Layout.maximumHeight: Layout.minimumHeight

With testing I found 5 pixel spacing. But couldn't trace where it comes from, 
maybe padding around items?. Used smallSpacing instead to avoid another magic 
number.

REPOSITORY
  R115 Plasma Audio Volume Applet

REVISION DETAIL
  https://phabricator.kde.org/D27117

To: gvgeo, #plasma, #vdg, drosca, ngraham, davidedmundson
Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to