Hi Ivan, Some feedback on what's in kde-review:
- Looks pretty good, yay! - Some of the param names specified in the doxygen magic don't match the argument names, eg. ID when the param is called wid. This will lead to doc warnings etc. - No use of Q_PROPERTY etc. This one is the only substantive issue I see. I think we should be defining the relevent property magic in these classes before they get moved from review. Other than that, nothing so far, but I'll keep looking. Looking good :-) Cheers Rich. _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
