davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision.
REVISION SUMMARY This is somewhat a simple fix for 5.18.0, but this really needs revisiting. The probelm is that newUserSetData is called N times for various properties. From the POV of this method, there is no way to no we're on teh last property. It simply checks for username and realname. However, the order the N properties are inserted is effectively undefined. The two things together don't work. This patch also blocks for the password. Ideally it needs to be setData, setData, setData, then some new flush method. There's a technical regression that you can no longer create a user account with no password, but that's arguably a feature. CCBUG: 416801 TEST PLAN Created a new user Looked in /etc/shadow REPOSITORY R128 User Manager BRANCH Plasma/5.18 REVISION DETAIL https://phabricator.kde.org/D26977 AFFECTED FILES src/lib/accountmodel.cpp To: davidedmundson, #plasma Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
