ngraham added a comment.
In D26665#601715 <https://phabricator.kde.org/D26665#601715>, @leinir wrote: > In D26665#601713 <https://phabricator.kde.org/D26665#601713>, @IlyaBizyaev wrote: > > > What about the "Get New Plugins" button in the same dialog? It still uses the old style. > > > The reason that wasn't changed in this step is simple - because it isn't simple ;) You'll notice that the change here was very much a trivial swap. Changing the other KNS integration points out for the new one will be considerably more effort, hence it isn't happening just yet. But now we have three different user interfaces for getting KNS content: 1. Discover 2. old dialog 3. new dialog. This is really kind of non-ideal. I was hoping we could swap out all the old dialogs for the new ones throughout System Settings and Plasma for 5.18. In the long term, I'd like to have //one// interface for all GHNS stuff, whether it be the new dialog or Discover, or something else. But three is now a regression in our quest for #goal_consistency <https://phabricator.kde.org/tag/goal_consistency/>. :/ In D26665#601715 <https://phabricator.kde.org/D26665#601715>, @leinir wrote: > In D26665#601713 <https://phabricator.kde.org/D26665#601713>, @IlyaBizyaev wrote: > > > And also, looking at @victorr's screenshot, I see that the "Close" button has no label on it. I got same problem here as well. > > > That really is a very strange error. Not sure why such a thing would fail. The code in question can be seen here: https://phabricator.kde.org/source/knewstuff/browse/master/src/qtquick/qml/Dialog.qml$98 - However, the whole thing is also being discussed elsewhere, making this the wrong place. Would be good to get more eyes on the situation :) https://bugs.kde.org/show_bug.cgi?id=413434 Just delete it :) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D26665 To: leinir, mart, #plasma, ngraham Cc: IlyaBizyaev, victorr, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
