zzag created this revision. zzag added reviewers: Plasma, broulik. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. zzag requested review of this revision.
REVISION SUMMARY Since a KWindowShadow is a child of QWindow, we need to use a guarded pointer to store the shadow in order to prevent accessing or deleting dangling pointers in ShadowHelper::_shadows. It's quite possible that one could destroy the associated widget and with it the QWindow. TEST PLAN plasmashell no longer crashes. REPOSITORY R31 Breeze BRANCH fix-crash REVISION DETAIL https://phabricator.kde.org/D26966 AFFECTED FILES kstyle/breezeshadowhelper.cpp kstyle/breezeshadowhelper.h To: zzag, #plasma, broulik Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
