ngraham created this revision. ngraham added reviewers: VDG, Plasma, hein, davidedmundson. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY Currently there's a top-level ColorScope that is almost entirely unused except for introducing a bug whereby the label text in the pop-up is the wrong color. Removing the ColorScope fixes the bug and does not change the appearance of anything else anywhere else. BUG: 416658 FIXED-IN: 5.18.0 TEST PLAN Hover over a folder and click on button to open a folder pop-up See that the text color is correct now: F7925905: After.png <https://phabricator.kde.org/F7925905> Use Folder view as a containment, as a widget, and in a panel See that text color is fine everywhere Use a bunch of different color schemes and repeat the above tests and see that everything still looks good REPOSITORY R119 Plasma Desktop BRANCH fix-folderview-popup-text-color (branched from master) REVISION DETAIL https://phabricator.kde.org/D26884 AFFECTED FILES containments/desktop/package/contents/ui/FolderViewLayer.qml To: ngraham, #vdg, #plasma, hein, davidedmundson Cc: plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
