> On 2010-04-09 16:03:45, Aaron Seigo wrote: > > > > Reza Shah wrote: > at trunk nextSlide is called on timeout signal and 'next wallpaper image' > context menu action. > since the trigger of nextSlide coming from different source, so my idea > was to add a simple guard to allow the wallpaper selected from 'Next > wallpaper image' menu to be displayed on proper interval. > > looking at the source code again, it's possible to add the patch directly > to nextSlide function like below: > m_timer.stop(); > renderWallpaper(current); > m_timer.start(m_delay * 1000); > > but i'm not sure if this is better or not.
it's fewer code paths to test and maintain which can't be a bad thing :) with that small change, please commit... - Aaron ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://reviewboard.kde.org/r/3529/#review4939 ----------------------------------------------------------- On 2010-04-09 06:53:02, Reza Shah wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://reviewboard.kde.org/r/3529/ > ----------------------------------------------------------- > > (Updated 2010-04-09 06:53:02) > > > Review request for Plasma. > > > Summary > ------- > > This patch change the behaviour of displaying wallpaper in slideshow mode. > In old behaviour it's possible the next slide selected from 'Next Wallpaper > Image' menu from context menu, > will not be displayed in proper interval. > > So in new behaviour timer is stopped before advancing to next slide. > > > Diffs > ----- > > trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.h 1112767 > trunk/KDE/kdebase/workspace/plasma/generic/wallpapers/image/image.cpp > 1112767 > > Diff: http://reviewboard.kde.org/r/3529/diff > > > Testing > ------- > > > Thanks, > > Reza > > _______________________________________________ Plasma-devel mailing list Plasma-devel@kde.org https://mail.kde.org/mailman/listinfo/plasma-devel
