davidedmundson requested changes to this revision. davidedmundson added a comment. This revision now requires changes to proceed.
One minor change, otherwise it's all good. INLINE COMMENTS > windowshadow.cpp:99 > + shadowManager->removeShadow(surface); > + surface->commit(KWayland::Client::Surface::CommitFlag::None); > + shadow = nullptr; Lets avoid this. Firstly it messes with Qt. We're doing this potentially during platform window initialisation, we're potentially committing before it's set some super important properties that we need set on the first commit. Secondly, we want it atomic with when the window updates (to a new theme or whatever) anyway. window->requestUpdate(); would be a compromise, it'll make Qt do a commit at the next available time. REPOSITORY R130 Frameworks integration plugin using KWayland REVISION DETAIL https://phabricator.kde.org/D26458 To: zzag, #kwin, davidedmundson Cc: davidedmundson, plasma-devel, Orage, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
