davidedmundson created this revision. davidedmundson added a reviewer: Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. davidedmundson requested review of this revision.
REVISION SUMMARY If the kcm's property changes externally we don't update the slider after the initial load, which is before KConfigModule::load which actually sets the property. Whilst there is an alternative fix calling load() a second time, we need this anyway for default and reset buttons to work correctly. I also think the original code was broken, I don't see why we would map the value back to modeOptions[idx], we want the slider value to be the index of the array, not the enum value. They just happen to be the same. TEST PLAN Opened KCM changed it, opened KCM repeat REPOSITORY R120 Plasma Workspace BRANCH origin-master (branched from master) REVISION DETAIL https://phabricator.kde.org/D26678 AFFECTED FILES kcms/feedback/package/contents/ui/main.qml To: davidedmundson, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
