ngraham added a comment.

  In D26530#593152 <https://phabricator.kde.org/D26530#593152>, @mart wrote:
  
  > yes, i'm saying that the patch besides putting the separation in the frame, 
it also reintroduces the frame by default, which is unrelated (and i think it 
should be avoided)
  
  
  Let's distinguish and lines. A frame is a four-cornered outline. What we see 
in the following image has no frames:
  
  F7880630: image.png <https://phabricator.kde.org/F7880630>
  
  IMO using lines to separate distinct elements that touch the bounds of the 
window is 1000% better than putting everything in a frame floating on the view, 
separated by a few pixels of padding. You can add more lines (within reason) 
without the view becoming overwhelming and heavy and old-fashioned looking I 
love love love the Kirigami style that does this, and in fact our T10891: 
Breeze theme evolution <https://phabricator.kde.org/T10891> task proposes 
moving to this style for QWidgets apps too.

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D26530

To: ahiemstra, #plasma, #goal_consistency, mart
Cc: kmaterka, mart, ndavis, IlyaBizyaev, ngraham, broulik, plasma-devel, 
LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, 
ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, 
sebas, apol, ahiemstra

Reply via email to