jgrulich added a comment.
In D26392#592288 <https://phabricator.kde.org/D26392#592288>, @ngraham wrote: > In D26392#592133 <https://phabricator.kde.org/D26392#592133>, @jgrulich wrote: > > > Can someone please look into this review? Either try it or check the code? I would like to have this as part of Plasma 5.18 and deadline for that is in few days. @ngraham how is it going with the icon? > > > @cblack is working on it IIRC. It's too late to show the icon in Plasma 5.18 anyway (the icon will be in the breeze-icons repo which is a framework, and Frameworks 5.66 which Plasma 5.18 relies on has already been tagged. So there's no huge rush there IMO. > > I'm still unable to test this because of the odd build failure that I cannot understand, explain, or overcome. :/ Then I'm not sure what to use instead. If I use a regular button with text, it won't definitely fit there with some translations. In Czech for example it would be "Vytvořit přístupový bod" which takes quite a lot of space, thus I would prefer just a button with an icon. If the icon is created, we can ship it together with plasma-nm for this release. REPOSITORY R116 Plasma Network Management Applet REVISION DETAIL https://phabricator.kde.org/D26392 To: jgrulich, #plasma, ngraham, #vdg Cc: cblack, alexde, mthw, apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, ahiemstra, mart
