ngraham added a comment.

  In D26586#592707 <https://phabricator.kde.org/D26586#592707>, @kmaterka wrote:
  
  > In D26586#592050 <https://phabricator.kde.org/D26586#592050>, @ngraham 
wrote:
  >
  > > Much better! The scrollview needs a frame around it though. You can do 
this by adding this to it:
  >
  >
  > Is it decided (D26530 <https://phabricator.kde.org/D26530>)? Correct me if 
I'm wrong, in Kirigami scrollbars are overlaying with transparent background, 
Kirigami just adds some paddings when needed. Anyway, to have scrollbar 
seprated it is better to just add one margin to the list (and remove 
"rightPadding" I added to header, section and list item).
  
  
  The discussion about overlay vs non-overlay scrollbars is unrelated to 
whether or not to show a frame and background behind a scrollview. :) Just add 
the background for now I think.

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D26586

To: kmaterka, #plasma_workspaces, #plasma, davidedmundson, broulik, ngraham
Cc: meven, nicolasfella, plasma-devel, ngraham, LeGast00n, The-Feren-OS-Dev, 
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to