davidedmundson added inline comments.
INLINE COMMENTS
> main.cpp:254
>
> -void IconModule::getNewStuff(QQuickItem *ctx)
> +void IconModule::ghnsEntriesChanged(const QQmlListReference &changedEntries)
> {
FWIW, there is an alternative approach that we do in plasma-workspace
(shell/containmentconfigview.cpp) for reloading wallpapers types.
kpackage emits a DBus signal when it performs an action, models can listen for
this.
We had to do that there because the model was quite separated from the UI.
But it has the advantage that we pick up external changes (i.e through discover
or whatever)
> main.cpp:275
> - if (ctx && ctx->window()) {
> - m_newStuffDialog->windowHandle()->setTransientParent(ctx->window());
> }
Does this code still exist? I can't see an equivalent in knewstuff.
It's especially important on wayland
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D26544
To: leinir, mart
Cc: davidedmundson, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
