tcanabrava updated this revision to Diff 73188. tcanabrava marked an inline comment as done. tcanabrava added a comment.
- Remove code dependant on Qt 5.14 - Mark that we will use some text in the future - Remove uneeded virtual - Update role names to something more explicit - Correctly handle wrong indices - Update Qml Library - Handle keyboard navigation - Use correct method for extracting data from the model - Nitpicks - Correctly compare locales - Fix metadata REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D25449?vs=73145&id=73188 BRANCH arcpatch-D25449 REVISION DETAIL https://phabricator.kde.org/D25449 AFFECTED FILES kcms/formats/CMakeLists.txt kcms/formats/Messages.sh kcms/formats/README kcms/formats/formats.desktop kcms/formats/formatsettings_impl.cpp kcms/formats/formatsettings_impl.h kcms/formats/formatssettings.kcfg kcms/formats/formatssettings.kcfgc kcms/formats/kcm.cpp kcms/formats/kcm.h kcms/formats/kcm_formats.desktop kcms/formats/kcmformats.cpp kcms/formats/kcmformats.h kcms/formats/kcmformatswidget.ui kcms/formats/localemodel.cpp kcms/formats/localemodel.h kcms/formats/package/contents/ui/CountryList.qml kcms/formats/package/contents/ui/LocaleInput.qml kcms/formats/package/contents/ui/main.qml kcms/formats/package/metadata.desktop kcms/formats/writeexports.h To: tcanabrava, ervin, #vdg, #plasma, mart Cc: mart, ngraham, broulik, ervin, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
