meven marked 2 inline comments as done. meven added inline comments. INLINE COMMENTS
> mlaurent wrote in CMakeLists.txt:14 > Why adding it ? it's autogenerated so it's added by cmake directly The issue was that add_library takes directly a list of cpp directly, but ecm_qt_declare_logging_category needs a list of SRCS to append its generated cpp file. The cmake file was lacking _SRCS list variable in sum. REPOSITORY R134 Discover Software Store REVISION DETAIL https://phabricator.kde.org/D26533 To: meven, apol, ngraham, mlaurent Cc: mlaurent, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
