romangg added inline comments.
INLINE COMMENTS
> davidedmundson wrote in orientation_sensor.cpp:29
> From what I can tell, we can call
>
> if (!sensor->connectToBackend()) {
> m_available = false;
> }
>
> in the constructor
>
> and then we have the option to call start/stop whenever.
Yea, I overlooked this getter. Will replace.
> davidedmundson wrote in orientation_sensor.h:38
> I don't really understand.
>
> The only reason to wrap QOrientationSensor in a wrapper class is to try and
> encapsulate the details of the sensor into something domain specific.
>
> If we just forward everything 1:1, what does this wrapper provide over just
> having the other code use QOrietnationSensor directly.
>
> (but whatever this isn't a topic I'm particularly passionate about, so
> whatever)
Yea, the "just use QOrientationSensor enum" argument makes sense. I will try to
use this instead.
REPOSITORY
R104 KScreen
REVISION DETAIL
https://phabricator.kde.org/D26037
To: romangg, #plasma
Cc: plasma-devel, davidedmundson, LeGast00n, The-Feren-OS-Dev, jraleigh,
zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf,
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
