meven updated this revision to Diff 72099. meven marked 4 inline comments as done. meven added a comment.
Keep isDefaults virtual, fix a fishy ref&, space formatting REPOSITORY R119 Plasma Desktop CHANGES SINCE LAST UPDATE https://phabricator.kde.org/D26100?vs=72053&id=72099 BRANCH component-browser REVISION DETAIL https://phabricator.kde.org/D26100 AFFECTED FILES kcms/componentchooser/CMakeLists.txt kcms/componentchooser/browser_settings.kcfg kcms/componentchooser/browser_settings.kcfgc kcms/componentchooser/componentchooser.cpp kcms/componentchooser/componentchooser.h kcms/componentchooser/componentchooserbrowser.cpp kcms/componentchooser/componentchooserbrowser.h kcms/componentchooser/componentchooseremail.cpp kcms/componentchooser/componentchooseremail.h kcms/componentchooser/componentchooserfilemanager.cpp kcms/componentchooser/componentchooserfilemanager.h kcms/componentchooser/componentchooserterminal.cpp kcms/componentchooser/componentchooserterminal.h kcms/componentchooser/kcm_componentchooser.cpp To: meven, crossi, #plasma, ngraham, ervin Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart