ngraham accepted this revision. ngraham added a comment. This revision is now accepted and ready to land.
All right, LGTM them! INLINE COMMENTS > jgrulich wrote in ConfigurationDialog.qml:55 > The Configuration class contains only static methods, which means you cannot > emit signal from them without passing the object or something like that. Maybe add a TODO comment explaining this then REPOSITORY R116 Plasma Network Management Applet BRANCH kcm-config REVISION DETAIL https://phabricator.kde.org/D26041 To: jgrulich, ngraham, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
