ndavis added a comment.
In D25539#578688 <https://phabricator.kde.org/D25539#578688>, @romangg wrote: > In D25539#578624 <https://phabricator.kde.org/D25539#578624>, @liushuyu wrote: > > > Any other suggestions for this patch? > > > From a UX perspective the general question is if a revert timer makes sense when we have already the "Apply" action. As previously said I think it makes sense if we had instant-apply. I am currently going into this direction with D26038 <https://phabricator.kde.org/D26038> but it does not yet do instant-apply. So my current leaning would be to wait until we have that and then revisit the revert timer. > > Could you look in a separate patch into how instant-apply would work with the current KScreen KCM (or on top of D26038 <https://phabricator.kde.org/D26038>)? That would be great. I think it makes sense with or without instant apply. You can accidentally make the UI unusable by messing with your screen settings, so having a timer to automatically revert isn't useless. An apply button doesn't save you when you've accidentally applied unusable settings. REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma, romangg Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, zachus, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
