cblack accepted this revision. cblack added a comment. This revision is now accepted and ready to land.
Code looks fine to me. For flatpaks not respecting the setting preference, have you checked that the dark theme variant is installed? f-d-o runtime doesn't offer an Adwaita-dark stub, while GNOME runtime does. As for xsettingsd, I'm not sure if it synchronises the dark theme preference. That doesn't appear to be in the xsettings spec afaik. REPOSITORY R99 KDE Gtk Configuration Tool BRANCH sync-dark-gtk3-theme-preference (branched from master) REVISION DETAIL https://phabricator.kde.org/D25945 To: gikari, apol, cblack, broulik, #vdg Cc: GB_2, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
