apol added inline comments.

INLINE COMMENTS

> kquickstyleitem.cpp:112
> +#else
> +    qmlRegisterAnonymousType<KQuickPadding>("org.kde.qqc2-desktop-style", 1);
> +#endif

Maybe use `org.kde.qqc2desktopstyle.private` which we are already using?

Also shouldn't we be registering the types and the plugin class rather than on 
every instance of the type?

REPOSITORY
  R858 Qt Quick Controls 2: Desktop Style

REVISION DETAIL
  https://phabricator.kde.org/D25709

To: mlaurent, apol
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to