ngraham added a reviewer: romangg. ngraham added a comment.
Yeah, it would be good to know the history on that. Also, please change the title to "feat(kcm): add a revert timer to the settings page" to comply with KScreen's new commit message guidelines. INLINE COMMENTS > main.qml:32 > property int selectedOutput: 0 > + property int revertCountdown: 10 > Doesn't seem to be used; the timer duration is hardcoded on the C++ side > main.qml:110 > + } > + standardButtons: StandardButton.Save | StandardButton.Cancel > + } I would change these to `StandardButton.Apply` and `StandardButton.Discard` REPOSITORY R104 KScreen REVISION DETAIL https://phabricator.kde.org/D25539 To: liushuyu, #vdg, #plasma, romangg Cc: ngraham, broulik, ndavis, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
