tcanabrava created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. tcanabrava requested review of this revision.
REVISION SUMMARY Before we port this to Qml we need to simplify the code it's currently monolithycal, and need to be split into at least two models and a few helper classes. Load Emoticon from the Models Problem: Something is *very* heavy. I think creating and destroying KEmoticons is not the best approach, I'll load everything and store in memory for next commit REPOSITORY R119 Plasma Desktop BRANCH kcm_emoticon REVISION DETAIL https://phabricator.kde.org/D25379 AFFECTED FILES kcms/emoticons/CMakeLists.txt kcms/emoticons/editdialog.cpp kcms/emoticons/editdialog.h kcms/emoticons/emoticonslist.cpp kcms/emoticons/emoticonslist.h kcms/emoticons/emoticonslist.ui kcms/emoticons/emoticonsmodel.cpp kcms/emoticons/emoticonsmodel.h kcms/emoticons/emoticonthemesmodel.cpp kcms/emoticons/emoticonthemesmodel.h kcms/emoticons/helpers.cpp kcms/emoticons/helpers.h To: tcanabrava Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
