ngraham created this revision. ngraham added reviewers: tcanabrava, Plasma. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. ngraham requested review of this revision.
REVISION SUMMARY The only reason why a user would want to entirely disable file indexing is because they don't want their files indexed. This implies that if their files are already indexed, they would like the index deleted. Ergo, disabling indexing in the KCM should delete the index too. This patch does that. The `balooctl` command-line tool offers more granular options for disabling without deleting the index, but those should be considered expert options for power users who know what they're doing. For users using the KCM, deleting the index after disabling indexing makes the most sense. BUG: 414077 FIXED-IN: 5.18.0 TEST PLAN 1. Run `balooctl monitor` 2. Disable indexing in the KCM 3. See that indexing has been turned off and the database deleted 4. Re-enable indexing in the KCM 5. See that files are being indexed as with a first run. REPOSITORY R119 Plasma Desktop BRANCH purge-index-when-disabling (branched from master) REVISION DETAIL https://phabricator.kde.org/D25280 AFFECTED FILES kcms/baloo/kcm.cpp To: ngraham, tcanabrava, #plasma Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
