ngraham added a comment.

  It doesn't compile:
  
    /home/nate/kde/usr/include/KF5/KNewStuff3/KNS3/DownloadDialog:1:10: fatal 
error: kns3/downloaddialog.h: No such file or directory
        1 | #include "kns3/downloaddialog.h"
          |          ^~~~~~~~~~~~~~~~~~~~~~~
  
  Also we should be using the new QML-based GHNS dialog where possible, now 
that it's a first-class citizen.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24224

To: tcanabrava, ngraham, bport
Cc: broulik, bport, ervin, mart, ngraham, whiting, plasma-devel, LeGast00n, 
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, 
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, 
ahiemstra

Reply via email to