davidedmundson added inline comments. INLINE COMMENTS
> ervin wrote in kcm.cpp:198 > Yes, it was never triggered. It turns out KKeySequenceWidget does that > already as soon as you pick a new shortcut, so it could never end up > conflicting here since said conflict would have been handled before. win win \o/ > ervin wrote in kscreensaversettings.cpp:46 > Not sure what you mean here. We're inside the KConfigSkeleton. > > Note that KGlobalAccel seems to expect a first call to setShortcut to > associate the local QAction with the information from KGlobalAccel. I admit > KGlobalAccel looks like an odd beast to me. > Note that KGlobalAccel seems to expect a first call to setShortcut to > associate the local. Oh, of course > I admit KGlobalAccel looks like an odd beast to me. It is. > davidedmundson wrote in kscreensaversettings.cpp:48 > Could we handle the alternative shortcut by using a second property? Fair answer :) I was getting further ahead in my head and trying to port the other KCMs. REPOSITORY R133 KScreenLocker REVISION DETAIL https://phabricator.kde.org/D25212 To: ervin, #plasma, davidedmundson, bport, crossi, mart Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
