ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Just a recurring typo, otherwise LGTM
INLINE COMMENTS
> kcm.cpp:220
> +
> + //Model has been cleared so pretend the selected look and fell changed
> to force view update
> + emit m_settings->lookAndFeelPackageChanged();
s/fell/feel/ :-)
> kcm.h:38
> Q_OBJECT
> + Q_PROPERTY(LookAndFeelSettings *lookAndFellSettings READ
> lookAndFellSettings CONSTANT)
> Q_PROPERTY(QStandardItemModel *lookAndFeelModel READ lookAndFeelModel
> CONSTANT)
s/Fell/Feel/
> kcm.h:64
>
> - //List only packages which provide at least one of the components
> - QList<KPackage::Package> availablePackages(const QStringList
> &components);
> -
> + LookAndFeelSettings *lookAndFellSettings() const;
> QStandardItemModel *lookAndFeelModel() const;
s/Fell/Feel/
> main.qml:32
> view.model: kcm.lookAndFeelModel
> - view.currentIndex: kcm.selectedPluginIndex
> + view.currentIndex:
> kcm.pluginIndex(kcm.lookAndFellSettings.lookAndFeelPackage)
> view.delegate: KCM.GridDelegate {
s/Fell/Feel/
> main.qml:58
> onClicked: {
> - kcm.selectedPlugin = model.pluginName;
> + kcm.lookAndFellSettings.lookAndFeelPackage = model.pluginName;
> view.forceActiveFocus();
s/Fell/Feel/
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D25274
To: crossi, #plasma, ervin, mart, bport, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
