gikari created this revision. Herald added a project: Plasma. Herald added a subscriber: plasma-devel. gikari requested review of this revision.
REVISION SUMMARY Previously GTK KCM wrote to gtkrc redundant settings lines: 1. `include "path to chosen gtk2 theme"` 2. style "user-font" { font-name="whatever font was chosen" } widget_style "*" style "user-font" Now GTK KCM does not write those lines to configuration file, but ones that was kept from previous versions of KCM are causing various glitches, when applying gtk2 configuration, for theme and font configs respectively. This patch fixes these issues removing these lines from gtkrc by force, after applying any configuration from GTK KCM. BUG: 413678 BUG: 413107 TEST PLAN Open ~/gtkrc-2.0 and add those lines (theme and font name are arbitrary): ========================================================================= include "/usr/share/themes/Adwaita-dark/gtk-2.0/gtkrc" style "user-font" { font_name="Noto Sans Regular" } widget_class "*" style "user-font" 1. Open GTK KCM and apply any configuration 2. Reopen ~/gtkrc-2.0 file and check, that those lines were removed REPOSITORY R99 KDE Gtk Configuration Tool BRANCH remove-legacy-gtkrc-settings (branched from master) REVISION DETAIL https://phabricator.kde.org/D25147 AFFECTED FILES src/appearancegtk2.cpp src/appearancegtk2.h To: gikari Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart