ervin added a comment.

  nitpick, but otherwise LGTM, giving time to others (in particular Nate) to 
chip in.

INLINE COMMENTS

> iconsmodel.cpp:87
>              }
> -
>              emit pendingDeletionsChanged();

I'd say keep the empty line please.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D24847

To: bport, mart, ervin, #plasma, crossi
Cc: bport, ngraham, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, 
jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, 
lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to