ervin added inline comments.

INLINE COMMENTS

> davidedmundson wrote in renderer.kcfg:10
> Will this mean we write "automaticloop" to the config file?
> 
> If so, we'll need to change  the KQuickAddons::QtQuickSettings::init
> As it passes the variables in the config directly to Qt envs, which wouldn't 
> be ideal.

Nope. KConfigXT is so clever that if you write a value which is the default to 
it, it kills the key in the config file instead. :-)

This is why you always want KConfigXT btw, managing defaults is error prone, 
people forget to kill the key when they do readEntry/writeEntry manually... 
which means you got something in the config file when the default changes, so 
you don't see the new default.

REPOSITORY
  R119 Plasma Desktop

REVISION DETAIL
  https://phabricator.kde.org/D25068

To: ervin, #plasma, mart, davidedmundson
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, 
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to