filipf added a comment.
In D25043#556268 <https://phabricator.kde.org/D25043#556268>, @ndavis wrote: > In D25043#555976 <https://phabricator.kde.org/D25043#555976>, @filipf wrote: > > > Not a fan of this for 2 reasons: > > > > - we have no control over color schemes; they might have dumb values for this color; in fact this is what I get now when testing this patch with Breeze and the Breeze Dark color scheme: F7685168: Screenshot_20191029_141614.png <https://phabricator.kde.org/F7685168> > > - it's not consistent with how this effect is achieved elsewhere in Plasmashell (where the opacity is 0.6 and not 0.5 or 0.3, so it seems that was wrong here). > > > > I'd just raise the opacity values instead. > > > Wait, this is the Breeze Dark colorscheme with the Breeze desktop theme? The desktop theme that gets its colors from the system colorscheme? If so, something is seriously wrong here. No, it's OK. These two patches are the dependencies: - https://github.com/KDE/plasma-framework/commit/5f46dd6bd52a2aac7f879eb7f14d26dc2cab5e3c - https://github.com/KDE/plasma-framework/commit/1f6d7591e96a48823e3f152bc52f8c9066165de4 But I did a quick test with different themes and the results confirm my suspicions about this patch now working great with other themes. McMojave: F7689729: Screenshot_20191029_234338.png <https://phabricator.kde.org/F7689729> Qogir: F7689733: Screenshot_20191029_234234.png <https://phabricator.kde.org/F7689733> Arc Color: F7689736: Screenshot_20191029_234421.png <https://phabricator.kde.org/F7689736> The old always present problem with dark themes is traded in for a sometimes present issue with both dark and light themes. Can we please test and discuss this some more? REPOSITORY R112 Milou REVISION DETAIL https://phabricator.kde.org/D25043 To: broulik, #plasma, #vdg, davidedmundson Cc: ndavis, filipf, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
