broulik added inline comments.

INLINE COMMENTS

> LockScreenUi.qml:37
>      readonly property bool softwareRendering: GraphicsInfo.api === 
> GraphicsInfo.Software
> +    readonly property bool lightBackground: 
> Math.max(PlasmaCore.ColorScope.backgroundColor.r, 
> PlasmaCore.ColorScope.backgroundColor.g, 
> PlasmaCore.ColorScope.backgroundColor.b) > 0.5
>  

Would it make more sense to use `hsvValue` or `hslLightness`?

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24997

To: filipf, #plasma, #vdg, ngraham
Cc: broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to