davidedmundson added inline comments.

INLINE COMMENTS

> apol wrote in org.kde.KWin.Session.xml:7
> Here it recommends using uint for such things:
> https://dbus.freedesktop.org/doc/dbus-api-design.html#interface-files

It also advocates for use of {sv} in your spec which is inherently string based.

I'm happy to use ints, as long as we then don't get into that trap of saying; 
"now we have an enum to sync in two places, we must create a header file and a 
dependency "

REPOSITORY
  R120 Plasma Workspace

REVISION DETAIL
  https://phabricator.kde.org/D24945

To: davidedmundson, #kwin
Cc: apol, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, 
GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, 
jensreuterberg, abetts, sebas, ahiemstra, mart

Reply via email to