bodoeggert added a comment.
The confusing thing about focus / hover colors is having to move away the mouse in order to see weather it's focused or toggled. I need to know: This button is pressed or not, that button will be interacted when I press space/enter. Highlighting the button under the mouse is an extra, it should not be too similar to the previously mentioned effects, and especially it should not be exactly like already having pressed the button. (If there is no toggle button, I need to have remembered the look of a toggled button.) @ngraham: If I'll interact with the selected button (not sure about the correct words here), this button should be marked most obviously, since I'll NOT interact with the default button by pressing enter. Otherwise (e.g. while having tabbed to a different input element), the default button should be the most obvious one. Maybe I'll describe it in HTML: <input type=text name=t><textarea name=ta></textarea><input type=button name=foo><input type=submit name=submit> If I tab to t, the default button should be the most obvious, even if I hover the mouse above foo. If I tab to ta, maybe the default button should be less obvious since enter will not press it? If I tab to foo, foo should be the most obvious button, even if I mouse-hover submit, since enter/space will push foo. If I tab to submit, it should have the same effect as foo just had. Hover effects will just duplicate "mouse is in clickable area", and with decent designs, you should already know that without the effect: <input type=togglebutton name=tb ><input type=submit name=submit> (I just invented a HTML toggle button) I get distracted, come back to my desk and see the dialog. Disregarding the mouse cursor, I should see weather tb is pressed. When I move away the mouse, it should not optically un-toggle itself: "Ah that was the focus color, not the pressed-down-color!" One more thing, I don't know weather it's a theme issue at all (probably not): Some applications will start an action on clicking a button. I remember these buttons to optically do nothing or just be pressed as long as the mouse button is, then … invisible background action ... then a modal dialog pops up. I'd prefer these buttons to remain pressed down until the modal dialog closes. (Also you should not use toggle buttons outside toolbars, use checkboxes with clickable labels instead, ¢¢) REPOSITORY R31 Breeze REVISION DETAIL https://phabricator.kde.org/D24706 To: ndavis, #vdg, #breeze Cc: bodoeggert, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, cblack, konkinartem, ian, jguidon, hannahk, Ghost6, jraleigh, MrPepe, fbampaloukas, squeakypancakes, alexde, IohannesPetros, GB_2, trickyricky26, ragreen, mglb, crozbo, ndavis, ZrenBot, firef, alexeymin, skadinna, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, aaronhoneycutt, abetts, sebas, apol, ahiemstra, mbohlender, mart
