davidedmundson added a comment.
I agree with Nate's comment, but lets get this in and then tackle that there.
I just one QML line that I don't follow, then lets ship it
INLINE COMMENTS
> main.qml:41
>
> - QQC2.CheckBox {
> - Layout.topMargin: Kirigami.Units.gridUnit
> - Layout.bottomMargin: Kirigami.Units.gridUnit
> - Layout.alignment: Qt.AlignHCenter
> - checked: kcm.feedbackEnabled
> - onToggled: kcm.feedbackEnabled = checked
> - text: i18n("Allow KDE software to collect anonymous usage
> information")
> + type: Kirigami.MessageType.Error
> + visible: !form.enabled
warning? It's not really an error exactly if it's configured.
> main.qml:112
> QQC2.Label {
> Layout.alignment: Qt.AlignHCenter
> Layout.maximumWidth: root.width * 0.5
Option to consider with regards to Nate's comment:
enabled: slider.value > 0
so it greys out really showing it's disabled, but still has the useful text.
> main.qml:116
> + text: {
> + feedbackController.applicationName
> + return
> feedbackController.telemetryDescription(statisticsModeSlider.modeOptions[statisticsModeSlider.value])
I don't understand this top line
REPOSITORY
R120 Plasma Workspace
REVISION DETAIL
https://phabricator.kde.org/D24733
To: apol, #plasma, vkrause, davidedmundson, ngraham
Cc: plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2,
ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed,
jensreuterberg, abetts, sebas, apol, ahiemstra, mart
