davidedmundson accepted this revision.
davidedmundson added inline comments.
INLINE COMMENTS
> appletslayout.cpp:534
> + QMouseEvent *me = static_cast<QMouseEvent *>(event);
> + if (me->button() == Qt::LeftButton || (me->buttons() &
> Qt::LeftButton)) {
> + mousePressEvent(me);
the first clause seems redundant
> appletslayout.cpp:593
> && m_mouseDownWasEditMode
> + && (event->source() == Qt::MouseEventSynthesizedBySystem
> + || event->source() == Qt::MouseEventSynthesizedByQt)
Please comment what this is doing.
> want with normal mouse the edit mode not being dismissed when clicking on
> empty areas but to do it on touch
> shellcorona.cpp:220
> +
> + connect(qApp, &QGuiApplication::focusWindowChanged,
> + this, [this] (QWindow *focusWindow) {
that's clever
REPOSITORY
R120 Plasma Workspace
BRANCH
mart/editMode
REVISION DETAIL
https://phabricator.kde.org/D24264
To: mart, #plasma, #vdg, ngraham, GB_2, davidedmundson
Cc: GB_2, ngraham, davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev,
jraleigh, fbampaloukas, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
