sitter added a comment.

  When I put the code in a minimal standalone program I can confirm that the 
code works just fine. Are you sure your testing methodology is sound @ngraham ?
  
  In point of fact
  
    if (url.isEmpty()) {
  
  should actually be `url.isValid` because the requirement is not just that it 
needs to be nonempty but also valid, and when changed that condition would show 
more clearly that the right code is run as the KIO warning should disappear.

REPOSITORY
  R114 Plasma Addons

REVISION DETAIL
  https://phabricator.kde.org/D24727

To: guoyunhe, #plasma
Cc: sitter, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart

Reply via email to