meven added a subscriber: anthonyfieroni.
meven added a comment.
ping @zzag @mart Any feedback
INLINE COMMENTS
> meven wrote in windowsystem.cpp:173
> I can't explain the current logic.
>
> @mart Do you think I should change the logic to give it more sense ?
>
> Perhaps make the 24, 40.. values match the iconWidth i.e :
>
> if (width <= 16){
> iconWidth = 16;
> else if (width <= 32)
> iconWidth = 32
> else if (width <= 48){
> iconWidth = 48
> ...
@anthonyfieroni Hey Anthony
Do you remember where the if comparison width values come from in your commit
https://cgit.kde.org/kwindowsystem.git/commit/?id=e8762b96ae7a9fabc6af8fc5dcf2b82a7206053f
?
REPOSITORY
R130 Frameworks integration plugin using KWayland
REVISION DETAIL
https://phabricator.kde.org/D24683
To: meven, #kwin, davidedmundson
Cc: anthonyfieroni, mart, zzag, ngraham, plasma-devel, LeGast00n,
The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin,
himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol,
ahiemstra
