mart added inline comments.

INLINE COMMENTS

> UpdatesPage.qml:286
>                                      // since the version strings there are 
> really really long
> -                                    return availableVersion
> +                                    return i18nc("Do not translate or alter 
> \\x9", "%1 → %2\x9C%1 → %2\x9C%2", installedVersion, availableVersion);
> +                                } else {

this is very interesting and a good idea..
are you sure tough it doesn't cause binding loops?
i am trying to use the same in another thing and i can't seem to get rid of them

REPOSITORY
  R134 Discover Software Store

REVISION DETAIL
  https://phabricator.kde.org/D24713

To: ngraham, apol, broulik, #discover_software_store
Cc: mart, broulik, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, 
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, 
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra

Reply via email to