mart requested changes to this revision. mart added a comment. This revision now requires changes to proceed.
This is more a comment on the technical side. It seems quite a brittle implementation to me, and quite prone to breakage (anything that relies on PlasmaCore.Dialog trying to make with it things that weren't in its architecture is bound to break, and that class in general is not much touchable. also, assumes that the systray will be positioned in a panelon a screen edge, and since this is not enforced, it should not be assumed. Anything that wants to do such a sidebar.. that's really a panel (different window flags, different many things, but still is a containment of Plasma::Types::Vertical form factor and Plasma::Types::Right location, withthe plasmoids inside that would react to that concept. That would be quite an huge things touching pretty much every level down to plasma-framework, but i feel this approach wouldn't really work. On this systray plasmoid only, I would already prefer trying to give it a resize handle and allow generic vertical resizing (so also allowing to resize it to full height) is still not very robust, but at least kinda makes sense when the systray is not exactly where is expected (if necessary, there is quite some popup resizing code that was deleted still buried somewhere in years old git history) REPOSITORY R120 Plasma Workspace REVISION DETAIL https://phabricator.kde.org/D24567 To: filipf, #vdg, #plasma, mart Cc: mart, ngraham, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra
