ervin requested changes to this revision.
ervin added a comment.
This revision now requires changes to proceed.
Just a last nitpick.
INLINE COMMENTS
> CMakeLists.txt:24
> +kconfig_add_kcfg_files(kcm_cursortheme_PART_SRCS cursorthemesettings.kcfgc
> GENERATE_MOC)
> +install(FILES cursorthemesettings.kcfg DESTINATION ${KDE_INSTALL_KCFGDIR})
> add_library(kcm_cursortheme MODULE ${kcm_cursortheme_PART_SRCS})
Could that be moved in the install file section of the file? Everything related
to file installs (but not target installs...) seems to be at the end of that
file.
REPOSITORY
R119 Plasma Desktop
REVISION DETAIL
https://phabricator.kde.org/D24517
To: bport, #plasma, mart, ervin, davidedmundson
Cc: davidedmundson, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh,
fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai,
ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
