meven accepted this revision. meven added a comment. This revision is now accepted and ready to land.
Apart from the small nitpick seems good to me. INLINE COMMENTS > configeditor.cpp:51 > using qsp = QStandardPaths; > + > QString > configLocation(qsp::writableLocation(qsp::GenericConfigLocation)); Could you reset this file changes since it is only empty lines. REPOSITORY R119 Plasma Desktop BRANCH gtk-config-icon-theme REVISION DETAIL https://phabricator.kde.org/D24543 To: gikari, ngraham, meven Cc: meven, plasma-devel, LeGast00n, The-Feren-OS-Dev, jraleigh, fbampaloukas, GB_2, ragreen, ZrenBot, ngraham, alexeymin, himcesjf, lesliezhai, ali-mohamed, jensreuterberg, abetts, sebas, apol, ahiemstra, mart
